Implement fallback search logic when ICU is unavailable#297
Open
b6k-dev wants to merge 2 commits intomicrosoft:mainfrom
Open
Implement fallback search logic when ICU is unavailable#297b6k-dev wants to merge 2 commits intomicrosoft:mainfrom
b6k-dev wants to merge 2 commits intomicrosoft:mainfrom
Conversation
lhecker
reviewed
May 26, 2025
Member
Meanwhile you delivered two of the most outstanding PRs this project has received so far. Don't get impostor syndrome! 😅 FYI: I'll try to first review and merge #255 before merging this PR, unless you'd like to prioritize this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #172
Demo:
2025-05-26.21-08-44.mp4
This pr introduces a fallback Boyer–Moore–Horspool algorithm used for searching the buffer when the ICU library fails to load.
The implementation is working, however since I'm still getting used to writing rust and the time I can devote is quite limited the code probably needs some polishing (maybe better structuring is needed to reuse as much as possible between the ICU and non-ICU search operations).
Anyways I guess it is a good foundation to iterate on.